Abort more noisily #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[insert cat picture] PURRFECT. Thanks! I don't need the \n\n , one last line is enough. Thanks! |
|
I've tried this ( |
|
I'd prefer just one last line: cmirror: aborted |
cmirror may abort on various error conditions. There was a complaint,
that the error mesasge might be overlooked because of the normal
diagnostic output:
buczek@theinternet:~$ cmirror /tmp/a /tmp/b --delete
theinternet.molgen.mpg.de: creating empty ./1
theinternet.molgen.mpg.de: creating empty ./10
theinternet.molgen.mpg.de: creating empty ./2
theinternet.molgen.mpg.de: creating empty ./3
theinternet.molgen.mpg.de: creating empty ./4
theinternet.molgen.mpg.de: creating empty ./5
theinternet.molgen.mpg.de: creating empty ./6
theinternet.molgen.mpg.de: creating empty ./7
theinternet.molgen.mpg.de: creating empty ./8
theinternet.molgen.mpg.de: creating empty ./9
theinternet.molgen.mpg.de: rm -r ./xx
rm: cannot remove './xx/aa': Permission denied
buczek@theinternet:~$
To make this more clear, an additional diagnostic output was requested
to show that cmirror didn't finish its job:
buczek@theinternet:~$ cmirror /tmp/a /tmp/b --delete
theinternet.molgen.mpg.de: creating empty ./1
theinternet.molgen.mpg.de: creating empty ./10
theinternet.molgen.mpg.de: creating empty ./2
theinternet.molgen.mpg.de: creating empty ./3
theinternet.molgen.mpg.de: creating empty ./4
theinternet.molgen.mpg.de: creating empty ./5
theinternet.molgen.mpg.de: creating empty ./6
theinternet.molgen.mpg.de: creating empty ./7
theinternet.molgen.mpg.de: creating empty ./8
theinternet.molgen.mpg.de: creating empty ./9
theinternet.molgen.mpg.de: rm -r ./xx
rm: cannot remove './xx/aa': Permission denied
cmirror aborted
buczek@theinternet:~$
Implementation:
- Add code to `die()` to optionally show the additional
message. This can be selected by a global flag
- Let the master set that flag unless `--quiet` is selected
- Add code to `die()` so that it can be called with `die(NULL)` to show
only the optional additional message but no specific error message.
- Replace `_exit(1)` with `die(NULL)` n places where it was used to
abort the parent process after a child process, which as the duty to
emit the error messages for its operation, has failed.
donald
force-pushed
the
even-more-noise
branch
from
98946e7
to
96ff047
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmirror may abort on various error conditions. There was a complaint,
that the error mesasge might be overlooked because of the normal
diagnostic output:
To make this more clear, an additional diagnostic output was requested
to show that cmirror didn't finish its job:
Implementation:
Add code to
die()to optionally show the additionalmessage. This can be selected by a global flag
Let the master set that flag unless
--quietis selectedAdd code to
die()so that it can be called withdie(NULL)to showonly the optional additional message but no specific error message.
Replace
_exit(1)withdie(NULL)n places where it was used toabort the parent process after a child process, which as the duty to
emit the error messages for its operation, has failed.